You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the handling of the zksolc compiler metadata and adding a check for ZkSync chains in the deployment and transaction processes.
Detailed summary
In deploy-metadata.ts, the access to bytecodeUri for zksolc has been modified to safely handle potential undefined values.
In get-required-transactions.ts, a check for ZkSync chains is added, returning an empty object if the chain is ZkSync, indicating that no implementation constructor parameters are needed.
✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Your org has enabled the Graphite merge queue for merging into main
Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.
You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
joaquim-verges
deleted the
feat_optimize_zksync_contract_deployment_and_bytecode_handling
branch
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on enhancing the handling of the
zksolccompiler metadata and adding a check forZkSyncchains in the deployment and transaction processes.Detailed summary
deploy-metadata.ts, the access tobytecodeUriforzksolchas been modified to safely handle potential undefined values.get-required-transactions.ts, a check forZkSyncchains is added, returning an empty object if the chain isZkSync, indicating that no implementation constructor parameters are needed.